Skip-link targets and functionality #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works as expected for me. |
hannyle
approved these changes
Feb 8, 2021
blankdots
approved these changes
Feb 8, 2021
|
We might want to keep an eye on cypress-io/cypress#311 for https://docs.cypress.io/api/commands/type.html#Tabbing |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues where #148 left before new controls introduced in #149.
Skip-link focused
Hidebutton before but because this feature was deleted we need to focus different elements depending on submission type.Related issues
Fixes #98
Type of change
Changes Made
Testing